From 8d91d3c3d9495c20d481a39bdbb4d28151be86e5 Mon Sep 17 00:00:00 2001 From: Joel Farthing Date: Fri, 12 Jun 2026 00:16:24 -0500 Subject: [PATCH] common: gate empty-start reasoning extraction (#1955) Co-authored-by: Joel Farthing <262452229+joelfarthing@users.noreply.github.com> --- common/chat-auto-parser-generator.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/chat-auto-parser-generator.cpp b/common/chat-auto-parser-generator.cpp index 61bcd055..d78d4a3c 100644 --- a/common/chat-auto-parser-generator.cpp +++ b/common/chat-auto-parser-generator.cpp @@ -93,7 +93,8 @@ common_peg_arena autoparser::build_parser(const generation_params & inputs) cons } return build_chat_peg_parser([&](common_chat_peg_builder & p) { parser_build_context ctx(p, inputs); - bool extract_reasoning = inputs.reasoning_format != COMMON_REASONING_FORMAT_NONE; + bool extract_reasoning = + inputs.reasoning_format != COMMON_REASONING_FORMAT_NONE && (inputs.enable_thinking || !reasoning.start.empty()); ctx.extracting_reasoning = extract_reasoning && reasoning.mode != reasoning_mode::NONE; ctx.content = &content;